Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove divBasedFormLayout from jelly files #149

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

MarkEWaite
Copy link
Contributor

Remove divBasedFormLayout from jelly files

Versions older than Jenkins 2.277.1 have not been supported for many releases. Remove this code that always evaluates to use divBasedFormLayout.

Testing done

Viewed the global configuration page and added one or more items to it. No issues detected.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@MarkEWaite MarkEWaite requested a review from a team as a code owner June 10, 2023 18:52
@MarkEWaite MarkEWaite added the chore Maintenance label Jun 10, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) June 10, 2023 19:02
@MarkEWaite MarkEWaite disabled auto-merge June 10, 2023 19:02
@MarkEWaite MarkEWaite merged commit e2a9198 into jenkinsci:master Jun 12, 2023
15 checks passed
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Jun 22, 2023
The http-request plugin needs a new release to deliver the features
and bug fixes that have accumulated since its last release in Aug 2022.
Some of those new features and bug fixes include:

* Require Jenkins 2.361.4 as minimum Jenkins version
  (jenkinsci/http-request-plugin#128)
* JENKINS-69081 - Track credential usage
  (jenkinsci/http-request-plugin#113)
* JENKINS-69155 - Snapshot authentication credentials
  (jenkinsci/http-request-plugin#111)
* Upgrade HtmlUnit from 2.x to 3.x
  (jenkinsci/http-request-plugin#148)

Documentation improvements include:

* Improve feature descriptions in documentation
  (jenkinsci/http-request-plugin#141)
* Add URL details as part of the exception
  (jenkinsci/http-request-plugin#74)
* Add a response header example to documentation
  (jenkinsci/http-request-plugin#133)
* rewording of abstract section
  (jenkinsci/http-request-plugin#130)
* Drop redundant part of example
  (jenkinsci/http-request-plugin#122)

Maintenance improvements include:

* Remove divBasedFormLayout from jelly files
  (jenkinsci/http-request-plugin#149)

jenkinsci/http-request-plugin#150 is the pull
request that prompted this adoption request

Reverts part of pull request:

* jenkins-infra#2950
@MarkEWaite MarkEWaite deleted the remove-divBasedFormLayout branch August 13, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
1 participant