Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebDAV MKCOL method #150

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Add WebDAV MKCOL method #150

merged 1 commit into from
Jun 22, 2023

Conversation

cobexer
Copy link
Contributor

@cobexer cobexer commented Jun 19, 2023

MKCOL and PUT allow for write only WebDAV use to upload artifacts during the build

Add the WebDAV MKCOL method to the allowed list of methods. With it this plugin allows write only use of a WebDav server to upload artifacts (using MKCOL and PUT).

Testing done

The existing unittests verify the basic functionality.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira (none)
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes (none)
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@cobexer cobexer marked this pull request as ready for review June 21, 2023 14:08
@cobexer cobexer requested a review from a team as a code owner June 21, 2023 14:08
@cobexer
Copy link
Contributor Author

cobexer commented Jun 21, 2023

We have tested this patch internally and are happy with the results :) ready to merge

gounthar
gounthar approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@gounthar gounthar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
As it's some kind of a new feature, shouldn't we add a test so this portion of code gets tested?
Thanks.

@MarkEWaite
Copy link
Contributor

@cobexer would you be willing to provide an example in the README file based on your use? It isn't immediately obvious to me how I would use this and how it would help me.

@cobexer
Copy link
Contributor Author

cobexer commented Jun 22, 2023

@gounthar

As it's some kind of a new feature, shouldn't we add a test so this portion of code gets tested?

The existing tests actually execise all the added code and verify at least basic functionality (new code has 100% coverage)

I'll add a short example to the readme :)

@cobexer
Add WebDAV MKCOL method
f74a2cf 
MKCOL and PUT allow for write only WebDAV use to upload artifacts during the build
@cobexer
Copy link
Contributor Author

cobexer commented Jun 22, 2023

@MarkEWaite basic example is attached 🚀

@cobexer
Copy link
Contributor Author

cobexer commented Jun 22, 2023

Will we also get a release of the changes? It looks like this repo doesn't automatically publish master builds yet?

@MarkEWaite MarkEWaite merged commit 4daa2b8 into jenkinsci:master Jun 22, 2023
15 checks passed
@MarkEWaite
Copy link
Contributor

Yes, this plugin will be released with this change and the other pending changes. One of the pending changes is to require Jenkins 2.361.4 or newer. Over 80% of installations of the 1.16 release are already running 2.361.1 or newer, so there is not much risk that users will ignore the new release because they are running too old a version of Jenkins.

@MarkEWaite MarkEWaite mentioned this pull request Jun 22, 2023
Merged
6 tasks
MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Jun 22, 2023
@MarkEWaite
Let markewaite adopt http-request plugin
ca87a36 
The http-request plugin needs a new release to deliver the features
and bug fixes that have accumulated since its last release in Aug 2022.
Some of those new features and bug fixes include:

* Require Jenkins 2.361.4 as minimum Jenkins version
  (jenkinsci/http-request-plugin#128)
* JENKINS-69081 - Track credential usage
  (jenkinsci/http-request-plugin#113)
* JENKINS-69155 - Snapshot authentication credentials
  (jenkinsci/http-request-plugin#111)
* Upgrade HtmlUnit from 2.x to 3.x
  (jenkinsci/http-request-plugin#148)

Documentation improvements include:

* Improve feature descriptions in documentation
  (jenkinsci/http-request-plugin#141)
* Add URL details as part of the exception
  (jenkinsci/http-request-plugin#74)
* Add a response header example to documentation
  (jenkinsci/http-request-plugin#133)
* rewording of abstract section
  (jenkinsci/http-request-plugin#130)
* Drop redundant part of example
  (jenkinsci/http-request-plugin#122)

Maintenance improvements include:

* Remove divBasedFormLayout from jelly files
  (jenkinsci/http-request-plugin#149)

jenkinsci/http-request-plugin#150 is the pull
request that prompted this adoption request

Reverts part of pull request:

* jenkins-infra#2950
@cobexer cobexer deleted the add-mkcol-webdav-method branch June 22, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gounthar gounthar gounthar approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@cobexer @MarkEWaite @gounthar