fix proxy setting usage #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin should abide by the "No Proxy Host" list configured in Jenkins instead of blindly using the proxy if it is configured.
There is not reason to cause the Jenkins build exeuction to fail just because the notification was not sucessfully pushed to Zulip. We'll log a SEVERE level error to the server log instead.
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
butchyyyy
force-pushed
the
master
branch
2 times, most recently
from
279670e
to
00b5ba4
Compare
|
This plugin is now deprecated. You can submit the PR to it's successor https://github.com/jenkinsci/zulip-plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a fix to the usage of the Jenkins proxy settings as well as a fix to not throw an error directly into the build log and thus fail the build just because the zulip notification failed to publish correctly.