Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Version 1.0.1 does not sent any notifications to Zulip #18

Closed
Philipp1909 opened this issue Mar 11, 2019 · 6 comments
Closed

Plugin Version 1.0.1 does not sent any notifications to Zulip #18

Philipp1909 opened this issue Mar 11, 2019 · 6 comments

Comments

@Philipp1909
Copy link

Hello,
the plugin version 1.0.1 does not send any notifications to Zulip.
We are using a self-hosted installation and have configured a freestyle job in Jenkins. The exceptions for the proxy are also configured.
When starting the freestyle job the plugin does not react and there is no console output.
Stream, topic, Bot E-Mail, Bot API are 100% correct.

Any ideas?

Zulip Notification Settings
Zulip post Build

@butchyyyy
Copy link
Collaborator

Thanks for reporting.
Do i understand correctly that your self-hosted Zulip server is not reachable via proxy and you have it listed in the no proxy hosts (exceptions).
I think those settings are not applied in the plugin. There was a PR opened for the plugin predecessor.
I'll do some testing and should be able to roll out a fix soon.

@butchyyyy
Copy link
Collaborator

@Philipp1909 If you can please confirm the proxy assumption?

Also can you double check your log recorder output? If the message fails to go through you should defintely see something there. E.g. here's an error output when bad host is specified in Zulip Url configuration. For other unexpected errors the job itself should fail.

image

@Philipp1909
Copy link
Author

For our self hosted Zulip server a proxy is set up. Webhooks from our Jira system, for example, work without problems. The Jenkins Log Recorder shows me the following error message, both in the private stream and in the public stream and in both streams the bot is registered as user.

stream closed

If the build is successful and the build is faulty Tomcat catalina.out shows the following log errors:

12-Mar-2019 13:44:28.931 INFO [Executor #0 for master : executing ZulipFreestyleTest #33] hudson.model.Run.execute ZulipFreestyleTest #33 main build action completed: SUCCESS
12-Mar-2019 13:44:28.934 SEVERE [Executor #0 for master : executing ZulipFreestyleTest #33] jenkins.plugins.zulip.Zulip.post Error sending Zulip message: Stream closed

@butchyyyy
Copy link
Collaborator

butchyyyy commented Mar 12, 2019

Thanks for providing the details @Philipp1909
I managed to reproduce the Error sending Zulip message: Stream closed error when proxy is configured in Jenkins instance.
I should have a fix ready tomorrow.

@butchyyyy
Copy link
Collaborator

@Philipp1909 I have published version 1.0.3 Proxy fixes. It is now available in the update center (don't forget to update the plugin index).
The plugin now respects the no proxy hosts settings and also passes the user name password credentials to the proxy if set.

Please let me know if it helps.

@Philipp1909
Copy link
Author

Now it works well! Thanks for your Support @butchyyyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants