[JENKINS-33095] Fix circular dependency issue #2
Conversation
|
🐝 |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
|
@reviewbybees done (classing @daniel-beck's thumbs up as a bee) |
|
I don't think this plugin is no longer needed in 1.609 The core dep is old because those old versions don't have a l:icon tag to use while newer core versions has. |
| @@ -28,7 +28,7 @@ THE SOFTWARE. | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>1.520</version> | |||
| <version>1.609</version> | |||
There was a problem hiding this comment.
This would be a good case for the parent pom (plugin-pom). Just specify the jenkins.version as 1.609.
There was a problem hiding this comment.
this isn't actually a plugin - it's one of the submodules that is a plugin - so would be a bit more work, but...
given the severity of the issue (this causes credentials not to load which causes so much other stuff not to load that you can;t even start Jenkis) I wanted to do as small a change as possible (so it would be as uncontroversial as possible).
|
@rsandell if it is not needed then it should be replcaed with an empty plugin with no deps that targets 1.609+ @tfennelly? |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
Maybe plugin manager should break dependency cycle (exclude splitted plugin) in case of such cycles? |
jglick
changed the title
|
🐝 |
See JENKINS-28942, but in the meantime this is an emergency. |
|
Verified that the change fixes the issue. |
[JENKINS-33095] Fix circular dependency issue
Also requiring icon-shim 2.0.3 to force the user to pick up jenkinsci/icon-shim-plugin#2 and avoid JENKINS-33095.
JENKINS-33095
The core version that icon-shim uses is old so when run on a newer core the plugin manager will add dependencies to plugins that have been split from core. This causes an unwanted circular dependency as
matrix-authwas split from core post the original baseline and has a dependency oncloudbees-folder, which depends oncredentials, which depends onicon-shimwhich causes all these plugins to not load causing massive headaches....SEVERE: found cycle in plugin dependencies: (root=Plugin:credentials, deactivating all involved) Plugin:credentials -> Plugin:icon-shim -> Plugin:matrix-auth -> Plugin:cloudbees-folder -> Plugin:credentials@reviewbybees