Fix "IllegalArgumentException: Invalid range specified: (1, -1)" when editing style attribute in Jelly files
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duemir
requested changes
Oct 10, 2022
| @@ -103,7 +105,7 @@ runPluginVerifier { | |||
| // Rather arbitrarily chosen first releases of last three year. | |||
| // Product version in use statistics say last 3 major releases. It does not define "major release" though but | |||
| // but educated guess is that `year.version` is what is considered major. | |||
| ideVersions = ["2020.3.2", "2021.3.3", "2022.1"] | |||
| ideVersions = ["2020.3.4", "2021.3.3", "2022.2.3"] | |||
There was a problem hiding this comment.
These are only used by the Plugin Verifier. IMO, not relevant to the fix but OK to have.
| registrar.doneInjecting(); | ||
| } catch (IllegalArgumentException ignored) { | ||
| // occurs when syntax is malformed, like style=="" | ||
| } |
There was a problem hiding this comment.
Why rely on exceptions to handle this? It is, after all, an exception about this plugin not preparing the parameters correctly for an API. We can probably just add another if checking that textLength is greater than 2, i.e. there are two quotes and something in them.
There was a problem hiding this comment.
Right @duemir , pushed another commit!
duemir
approved these changes
Oct 10, 2022
duemir
changed the title
style attribute in Jelly files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Issue reproduced:
Changes:
build.gradletypeattribute inbuild.gradlein order to be able to use ultimate edition during testsvalue.getTextLength()To test:
runIde -PideaVersion=<some version> -PideaType=IU-> will run ultimate edition which contains CSS pluginreproduce steps, and see no exception, and completion works when syntax correctly fomed
Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue