Unused Stapler Facet is removed

[jgreffe]

Fixes #87

Remove all classes related to Facet
Remove all plugin.xml declarations related to Facet
Fixes infinite loop in JexlInspection.tokenize("'") : case ${%Test('
Fixes out of range issue with patterns like ${%Test(something)} (Argument rangeInElement (20,21) endOffset must not exceed descriptor text range (121, 141) length (20))

Upgrading to this new plugin version on existing projects having facet will popup a warning message:

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[duemir]

@timja I am on the fence about this. What do you think?

[timja]

Sounds fine to remove if it’s not being used, but not too familiar with this

[duemir]

OK. We should probably do it. It is unlikely that this Facet was ever used in the field by anybody but me.
But I think we should add a few more tests for JexlInspection, which is being published to a wider audience by this change. e.g., test that it handles property lookups (l10n) like ${%Name} and ${%Build Queue(items.size())}

[jgreffe]

Added some unit tests, and fixed two issues:

• infinite loop in JexlInspection.tokenize("'")
• out of range issue with patterns like ${%Test(something)} (Argument rangeInElement (20,21) endOffset must not exceed descriptor text range (121, 141) length (20))

[duemir]

A few minor suggestions.

I've confirmed the test fail and that changes in Jexl Inspection fix them. I have a hard time reasoning about this thing, so this is as best I can do in a limited time.

[duemir]

Oh boy! I built a local version of the next release. Ran the JEXL inspection on @jenkinsci/jenkins . It crashes in two files and shows 11 errors in 9 files.

4 has to do with localization. The rest is about HTML-encoded angle bracket 🤔

[jgreffe]

@duemir : this means as jexl inspection is now activated by default, it displays proper expected errors, but also points out some faulty plugin code (crashes) ?

[duemir]

@jgreffe Yes, as far as I can see. I will try to iron at least some out.

[jgreffe]

Crashes occur with i18n like:

<j:jelly xmlns:j="jelly:core">
    <p>
        ${%Te'st}</p>
</j:jelly>