Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Stapler Facet even needed? #87

Closed
duemir opened this issue Feb 22, 2022 · 2 comments · Fixed by #121
Closed

Is Stapler Facet even needed? #87

duemir opened this issue Feb 22, 2022 · 2 comments · Fixed by #121

Comments

@duemir
Copy link
Member

duemir commented Feb 22, 2022

What feature do you want to see added?

Stapler Facet is empty. It does not contain any framework-specific settings that need to be configured on the module.
It is essentially just a toggle for a few features.
Is it even necessary?

Upstream changes

No response

@duemir
Copy link
Member Author

duemir commented Sep 13, 2022

https://plugins.jetbrains.com/docs/intellij/facet.html
https://plugins.jetbrains.com/docs/intellij/project-structure.html#facet

There are currently no facet-specific configs and no facet-based tool windows. As stated above, it is used as a flag in JEXL checker, but that is about it.

Not really needed a the moment, it seems, but can there be a reason to use it?

@jgreffe
Copy link
Contributor

jgreffe commented Oct 19, 2022

Currently Facet is used only here:

protected final boolean shouldCheck(@NotNull PsiElement psiElement) {
return getFacet(psiElement) != null;
}

As a new Jelly language is introduced with #102, I think Facet will be useless afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants