[JENKINS-65068] RestartableJenkinsRule: Handle NoSuchFileException thrown from FileTreeWalker
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FileTreeWalker is quite a bit less hardened that one might hope. The visitor must handle a NoSuchFileException throw during copy, but the visitFileFailed method must handle NoSuchFileException if thrown by the walker.
jtnord
approved these changes
Apr 27, 2021
rsandell
approved these changes
Apr 27, 2021
|
@jglick Merge? |
jglick
changed the title
RestartableJenkinsRule: Handle NoSuchFileException thrown from FileTreeWalker
jglick
approved these changes
Apr 27, 2021
| }); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Just tried, but too late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileTreeWalker is quite a bit less hardened that one might hope.
The visitor must handle a NoSuchFileException throw during copy, but
the
visitFileFailedmethod must handle NoSuchFileException if thrownby the walker.
https://issues.jenkins.io/browse/JENKINS-65068
@jtnord @olamy