Terminology Cleanup: Introduce createAgent() and createOnlineAgent() in JenkinsRule
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` in `JenkinsRule`
oleg-nenashev
commented
Oct 17, 2021
offa
reviewed
Oct 21, 2021
offa
reviewed
Oct 21, 2021
Co-authored-by: offa <bm-dev@yandex.com>
Co-authored-by: offa <bm-dev@yandex.com>
|
Thanks for the review @offa ! |
|
@oleg-nenashev I've created a PR for your branch which fixes the conflicts. |
jglick
reviewed
Nov 3, 2021
| @@ -903,39 +903,89 @@ public File createTmpDir() throws IOException { | |||
| return env.temporaryDirectoryAllocator.allocate(); | |||
| } | |||
|
|
|||
| // TODO replace return types once the Jenkins core is updated | |||
There was a problem hiding this comment.
Do you really foresee such a class rename in core? Seems like a lot of disruption for a cosmetic issue.
There was a problem hiding this comment.
I do not expect it anytime soon TBH. Depends on contributions though
|
More inclined to just use the new terminology incrementally as changes are made, as in #428. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up API for JenkinsRule. I did not touch
HudsonTestCase, because we might want to drop JUnit 3 support alltogether