Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-14749 Update CSS error handler #424

Merged
merged 2 commits into from Apr 27, 2022
Merged

JENKINS-14749 Update CSS error handler #424

merged 2 commits into from Apr 27, 2022

Conversation

timja
Copy link
Member

@timja timja commented Apr 13, 2022 •
edited

This was referenced Apr 13, 2022
Merged
Merged
@timja timja requested a review from basil April 13, 2022 10:49
basil
basil reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR build is failing.

@timja
Copy link
Member Author

timja commented Apr 14, 2022

PR build is failing.

right, spotbugs exclusions were ignoring that in the outer class. I'd just copied it from further up =/.

@basil basil marked this pull request as ready for review April 27, 2022 17:54
@timja timja merged commit a0189dc into jenkinsci:master Apr 27, 2022
@timja timja deleted the cleanup-error-handler branch April 27, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timja @basil