Allow RealJenkinsRule controllers to know surefire.forkNumber
#513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
Nov 11, 2022
| ProcessBuilder pb = new ProcessBuilder(argv); | ||
| System.out.println("Launching: " + pb.command()); | ||
| pb.environment().put("JENKINS_HOME", home.getAbsolutePath()); | ||
| Map<String, String> env = new TreeMap<>(); |
There was a problem hiding this comment.
Nice touch to use something better than HashMap here (and consistent with hudson.EnvVars, which also uses TreeMap). It's too bad that ProcessBuilder#environment uses a HashMap internally, scrambling the order of whatever the user passes in. I wish hudson.EnvVars had extended LinkedHashMap (insertion order), because that is how libc's setenv(3) works, but that ship sailed a long time ago.
There was a problem hiding this comment.
As far as I know the ultimate order is irrelevant, but it is much nicer to print the variables in order below.
There was a problem hiding this comment.
but it is much nicer to print the variables in order below.
… which is why I wrote it was a nice touch above.
Vlatombe
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Maven property can be helpful to avoid conflicts between parallelized tests when using test services, if you cannot reliably randomize ports. Needs jenkinsci/plugin-pom#645 to ensure the property gets propagated from Maven to the Surefire booter JVM.