Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct key for Request.maxFormContentSize #605

Merged
merged 1 commit into from
Jun 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
import org.eclipse.jetty.server.HttpConnectionFactory;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
import org.eclipse.jetty.server.handler.ContextHandler;
import org.eclipse.jetty.util.security.Password;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
import org.eclipse.jetty.webapp.Configuration;
Expand Down Expand Up @@ -261,7 +262,7 @@
* @deprecated
* Use {@link #pluginManager}
*/
public boolean useLocalPluginManager;

Check warning on line 265 in src/main/java/org/jvnet/hudson/test/HudsonTestCase.java

View check run for this annotation

ci.jenkins.io / Java Compiler

dependency:copy

NORMAL: deprecated item is not annotated with @deprecated

/**
* Number of seconds until the test times out.
Expand Down Expand Up @@ -1608,7 +1609,7 @@
*/
@SuppressWarnings("unchecked")
@Override
public Page getPage(String url) throws IOException, FailingHttpStatusCodeException {

Check warning on line 1612 in src/main/java/org/jvnet/hudson/test/HudsonTestCase.java

View check run for this annotation

ci.jenkins.io / Java Compiler

dependency:copy

NORMAL: deprecated item is not annotated with @deprecated
try {
return super.getPage(url);
} finally {
Expand Down Expand Up @@ -1753,7 +1754,7 @@
});

// remove the upper bound of the POST data size in Jetty.
System.setProperty("org.mortbay.jetty.Request.maxFormContentSize","-1");
System.setProperty(ContextHandler.MAX_FORM_CONTENT_SIZE_KEY, "-1");
}

private static final Logger LOGGER = Logger.getLogger(HudsonTestCase.class.getName());
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/jvnet/hudson/test/JenkinsRule.java
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@
import org.eclipse.jetty.server.HttpConnectionFactory;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
import org.eclipse.jetty.server.handler.ContextHandler;
import org.eclipse.jetty.util.security.Password;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
import org.eclipse.jetty.webapp.Configuration;
Expand Down Expand Up @@ -323,7 +324,7 @@
* @deprecated
* Use {@link #pluginManager}
*/
public boolean useLocalPluginManager;

Check warning on line 327 in src/main/java/org/jvnet/hudson/test/JenkinsRule.java

View check run for this annotation

ci.jenkins.io / Java Compiler

dependency:copy

NORMAL: deprecated item is not annotated with @deprecated

/**
* Number of seconds until the test times out.
Expand Down Expand Up @@ -2579,7 +2580,7 @@
*/
@SuppressWarnings("unchecked")
@Override
public Page getPage(String url) throws IOException, FailingHttpStatusCodeException {

Check warning on line 2583 in src/main/java/org/jvnet/hudson/test/JenkinsRule.java

View check run for this annotation

ci.jenkins.io / Java Compiler

dependency:copy

NORMAL: deprecated item is not annotated with @deprecated
try {
return super.getPage(url);
} finally {
Expand Down Expand Up @@ -2862,7 +2863,7 @@
});

// remove the upper bound of the POST data size in Jetty.
System.setProperty("org.mortbay.jetty.Request.maxFormContentSize","-1");
System.setProperty(ContextHandler.MAX_FORM_CONTENT_SIZE_KEY, "-1");
}

private static final Logger LOGGER = Logger.getLogger(HudsonTestCase.class.getName());
Expand Down
Loading