Update search function for Command palette #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
May 21, 2024
…ns-test-harness into command-palette
14 tasks
timja
reviewed
May 26, 2024
| long startTime = System.currentTimeMillis(); | ||
|
|
||
| while (System.currentTimeMillis() - startTime < maxWaitTime) { | ||
| if (page.querySelector("*").getTextContent().contains(value)) { |
There was a problem hiding this comment.
can probably be simplified with asText()? https://stackoverflow.com/a/6538127/4951015
There was a problem hiding this comment.
Couldn't find the asText method, getVisibleText exists however so I've updated it with that
timja
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the search method to support the 'Command palette' introduced n jenkinsci/jenkins#7569. Also includes backwards compatibility for the classic YUI search bar.
Testing done
Submitter checklist