Skip to content
Permalink
Browse files
[FIXED JENKINS-10556] Auto Install JDK asks for Oracle account, but t…
…he link goes 404
  • Loading branch information
ssogabe committed Aug 2, 2011
1 parent 3e52131 commit 6f335c3d7e30cc7b96b09c3be3b74c526b06cb05
Showing with 4 additions and 2 deletions.
  1. +3 −1 changelog.html
  2. +1 −1 core/src/main/java/hudson/tools/JDKInstaller.java
@@ -55,7 +55,9 @@
<!-- Record your changes in the trunk here. -->
<div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
<ul class=image>
<li class=>
<li class=bug>
Auto Install JDK asks for Oracle account, but the link goes 404.
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-10556">issue 10556</a>)
</ul>
</div><!--=TRUNK-END=-->

@@ -630,7 +630,7 @@ public FormValidation doCheckId(@QueryParameter String value) {

public FormValidation doCheckAcceptLicense(@QueryParameter boolean value) {
if (username==null || password==null)
return FormValidation.errorWithMarkup(Messages.JDKInstaller_RequireOracleAccount(Stapler.getCurrentRequest().getContextPath()+getDescriptorUrl()+"/enterCredential"));
return FormValidation.errorWithMarkup(Messages.JDKInstaller_RequireOracleAccount(Stapler.getCurrentRequest().getContextPath()+'/'+getDescriptorUrl()+"/enterCredential"));

This comment has been minimized.

Copy link
@ndeloof

ndeloof Dec 16, 2011

Contributor

Should have used getCredentialPageUrl() here to avoid code duplication (and as well this bug)

if (value) {
return FormValidation.ok();
} else {

0 comments on commit 6f335c3

Please sign in to comment.