[FIXED JENKINS-19764] Ensure parent dir of new builds dir exists. #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -619,6 +619,9 @@ public void renameTo(String newName) throws IOException { | |||
| super.renameTo(newName); | |||
| File newBuildDir = getBuildDir(); | |||
| if (oldBuildDir.isDirectory() && !newBuildDir.isDirectory()) { | |||
| if (!newBuildDir.getParentFile().isDirectory()) { | |||
| newBuildDir.getParentFile().mkdirs(); | |||
There was a problem hiding this comment.
It makes sense to check mkdirs() result as well. According to Javadoc, it returns "true if and only if the directory was created, along with all necessary parent directories; false otherwise", Its better to just call File::exists() after the call
There was a problem hiding this comment.
@oleg-nenashev And then? What action would you take? You can't just abort a transaction here. Failing horribly on the subsequent builds dir rename doesn't seem to be that inappropriate.
|
core » jenkins-core #1322 SUCCESS |
daniel-beck
added a commit
that referenced
this pull request
Sep 5, 2014
[FIXED JENKINS-19764] Ensure parent dir of new builds dir exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.