Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed display of long descriptions in the build history pane #1382

Closed
wants to merge 1 commit into from

Conversation

GregOriol
Copy link

Broken display:
jenkins-build-history-broken

Fixed display:
jenkins-build-history-fixed

@cloudbees-pull-request-builder

core » jenkins-core #1336 SUCCESS
This pull request looks good

@daniel-beck
Copy link
Member

Is there a way to see the full text, e.g. in a tool tip?

@tfennelly
Copy link
Member

Ah... back to using ellipsis. @daniel-beck you didn't like that when I tried it before.

@daniel-beck
Copy link
Member

@tfennelly That was when there were no line breaks. This still breaks lines (see -> preprod) and just hides the end of insanely long words.

@tfennelly
Copy link
Member

@daniel-beck Ah cool... I just looked at the style changes and they look the same.

@GregOriol
Copy link
Author

@daniel-beck right now, I don't see any way to make a tooltip easily, this css change is the most simple fix to this, but indeed it could be great

@daniel-beck
Copy link
Member

An alternative variant using l:breakable would be interesting to see in comparison. Build and project name are already displayed using that in executors.jelly.

@jglick
Copy link
Member

jglick commented Aug 28, 2014

l:breakable would indeed be more consistent.

Maybe your build descriptions can just be made shorter to begin with? (master@1234abc -> preprod for example)

@GregOriol
Copy link
Author

@jglick indeed, but this is just an example of build description: it could have been anything else.

@daniel-beck
Copy link
Member

anything else

Well, anything with one single term that doesn't get word wrapped by the browser and is

  • ~30+ characters that are almost exclusively relatively wide in a proportional width font (no or few i, l, j, t, f, r), or
  • ~45+ characters otherwise (Pneumonoultramicroscopicsilicovolcanoconiosis fits!).

That should narrow it down considerably. How many build descriptions are likely to reference the Welsh town Llanfairpwllgwyngyll by its full name?

@GregOriol
Copy link
Author

I can think of:

  • a URL
  • a file path
  • some specific thing to a project (like my example)
    of course, in some cases there may be a need for a tooltip or the full data (scroll ?) but as a first step, the ellipsis would do the trick.

@daniel-beck
Copy link
Member

At least Firefox word wraps at / and \, so most URLs and file paths should display without problems. Additionally, build descriptions are truncated at (at most) 100 characters.

While it may look nicer for your specific case to hide the overflow, the conditions necessary to require this seem to be quite unusual. l:breakable, consistent with other parts of the UI, is the way to go here.

@oleg-nenashev
Copy link
Member

Cannot be merge due to the merge conflict (Pr from @tfennelly ?)

@oleg-nenashev oleg-nenashev added the needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging label Oct 17, 2015
@GregOriol
Copy link
Author

Not useful anymore

@GregOriol GregOriol closed this Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants