Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-16184] Also escape greater-than character #1420

Merged
merged 1 commit into from Oct 10, 2014

Conversation

daniel-beck
Copy link
Member

No description provided.

oleg-nenashev added a commit that referenced this pull request Oct 10, 2014
@oleg-nenashev oleg-nenashev merged commit d158334 into jenkinsci:master Oct 10, 2014
oleg-nenashev added a commit that referenced this pull request Oct 10, 2014
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
@KostyaSha
Copy link
Member

Btw, core has commons-lang dependency, why not use existed https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/StringEscapeUtils.html?

@daniel-beck
Copy link
Member Author

@KostyaSha As these already existed (and did 90% of the job) I just changed them to do the other 10%. Feel free to move this over to use commons-lang.

@KostyaSha
Copy link
Member

@jglick @kohsuke is there any reason why jenkins has commons dependency and doesn't use available methods?

@daniel-beck
Copy link
Member Author

@KostyaSha Because Util.escape(String) exists since Jan 2007 (91d7a93), and the commons-lang dependency in core since Feb 2009 (ec7d8a0, and that was only cosmetic). No point in rewriting things if they've existed and worked forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants