Replace crappy VersionNumber with better implementation. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h ASL and has a better understanding of Maven version numbers (with some tweaks for wildcard support) o Had to change the logic of two test cases (2.0 is now newer than 2.0.ea and 1.12-SNAPSHOT is no longer equal to 1.11.*) both of which make more sense than the original test cases o Should now allow custom builds with text/alpha qualifiers in the version number.
| ALIASES.put("ga", ""); | ||
| ALIASES.put("final", ""); | ||
| ALIASES.put("cr", "rc"); | ||
| ALIASES.put("ea", "rc"); |
There was a problem hiding this comment.
This alias is added to the Mercury ruleset to keep the results ordered correctly
|
simply using (wrap) http://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java doesn't work ? |
kohsuke
added a commit
that referenced
this pull request
Jun 7, 2011
Replace crappy VersionNumber with better implementation.
|
@olamy: wildcard support is the killer on that |
EstherAF
pushed a commit
to EstherAF/jenkins
that referenced
this pull request
May 13, 2020
[PRD-1389] Enable release only on branches (not via PR builders)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace old CDDL+GPLv2 Version Number comparator with one that is both ASL and has a better understanding of Maven version numbers (with some tweaks for wildcard support)
Signature of new version (based on the Mercury Version Number comparison code developed at Apache Maven):
public class hudson.util.VersionNumber extends java.lang.Object implements java.lang.Comparable{
public hudson.util.VersionNumber(java.lang.String); public int compareTo(hudson.util.VersionNumber);
public java.lang.String toString();
public boolean equals(java.lang.Object);
public int hashCode();
public boolean isOlderThan(hudson.util.VersionNumber);
public boolean isNewerThan(hudson.util.VersionNumber);
public int digit(int);
public int compareTo(java.lang.Object);
}
Signature of original version:
public class hudson.util.VersionNumber extends java.lang.Object implements java.lang.Comparable{
public hudson.util.VersionNumber(java.lang.String);
public int digit(int);
public java.lang.String toString();
public boolean isOlderThan(hudson.util.VersionNumber);
public boolean isNewerThan(hudson.util.VersionNumber);
public boolean equals(java.lang.Object);
public int hashCode();
public int compareTo(hudson.util.VersionNumber);
public int compareTo(java.lang.Object);
}