Fixed unstable builds showing "0 tests started to fail" when build was unstable for other reasons. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s unstable for other reasons.
|
This was a problem at our workplace. We had builds that were marked "unstable" because of CheckStyle violations. (Well, StyleCop, really) What was happening is that if the build was unstable, but had no failures, it would report "0 tests have started to fail." This is because it was assuming that an unstable build is due to tests, where, really, it can be caused by any plugin. The logic changes in the above commit address this. |
|
Integrated toward 1.417. Thanks! |
EstherAF
pushed a commit
to EstherAF/jenkins
that referenced
this pull request
May 13, 2020
…76-20190708 Fix regression in security fixes for July 17, 2.176.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unstable builds showing "0 tests started to fail" when build was unstable for other reasons than test failure.