[FIX JENKINS-27694] Update dynamically loaded plugins' Downloadables #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐝 |
| LOGGER.log(Level.FINE, "Updating metadata for " + d.getId()); | ||
| try { | ||
| d.updateNow(); | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
According to our previous experience, I would recommend to start catching other Throwables when we call extension points
There was a problem hiding this comment.
@oleg-nenashev The caller ExtensionListListener already handles these, so in the worst case not all necessary Downloadables are refreshed. Since I gate this with a check to only refresh those without data, it should only happen for a Downloadable in a plugin with 2+ Downloadables that is broken anyway.
|
@daniel-beck , the comment above is up to you. I think there's a risk of Runtime Exceptions in extensions |
|
🐝 |
daniel-beck
added a commit
that referenced
this pull request
Jul 5, 2015
[FIX JENKINS-27694] Update dynamically loaded plugins' Downloadables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JENKINS-27694.
@reviewbybees