New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify --webroot to the Windows service wrapper #1951

Merged
merged 1 commit into from Dec 21, 2015

Conversation

6 participants
@jglick
Member

jglick commented Dec 9, 2015

Otherwise we default to the war subdirectory of Jenkins home, which is

  • inefficient, if this is on a slower shared drive
  • dangerous, if using CloudBees high availability

Compare for example the RPM package which already sets --webroot.

@reviewbybees

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Dec 9, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Dec 9, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@recena

This comment has been minimized.

Show comment
Hide comment
@recena

recena Dec 10, 2015

Contributor

🐝

Contributor

recena commented Dec 10, 2015

🐝

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Dec 11, 2015

Member

Test failure looks unrelated.

@svanoort you probably want to review this.

Member

jglick commented Dec 11, 2015

Test failure looks unrelated.

@svanoort you probably want to review this.

@svanoort

This comment has been minimized.

Show comment
Hide comment
@svanoort

svanoort Dec 11, 2015

Member

@jglick 🐝 although does need testing.

Member

svanoort commented Dec 11, 2015

@jglick 🐝 although does need testing.

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Dec 11, 2015

Member

@svanoort yes…and do you volunteer to do that testing? (Do you have relevant infrastructure set up?)

Member

jglick commented Dec 11, 2015

@svanoort yes…and do you volunteer to do that testing? (Do you have relevant infrastructure set up?)

@svanoort

This comment has been minimized.

Show comment
Hide comment
@svanoort

svanoort Dec 11, 2015

Member

@jglick Oh, I assumed the change had been tested already (was just checking that). I think @jtnord may have something rigged up for windows testing though (I know he's got a flow up for the windows build anyway). (As always for these, infra is a huge part of the challenge.)

Member

svanoort commented Dec 11, 2015

@jglick Oh, I assumed the change had been tested already (was just checking that). I think @jtnord may have something rigged up for windows testing though (I know he's got a flow up for the windows build anyway). (As always for these, infra is a huge part of the challenge.)

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Dec 11, 2015

Member

The user experiencing the problem made the corresponding edit to the jenkins.xmls in their existing service wrappers and confirmed that this fixed the problem. However the source change has not been tested in the sense of creating a fresh Windows service from a Jenkins WAR built using this patch.

Member

jglick commented Dec 11, 2015

The user experiencing the problem made the corresponding edit to the jenkins.xmls in their existing service wrappers and confirmed that this fixed the problem. However the source change has not been tested in the sense of creating a fresh Windows service from a Jenkins WAR built using this patch.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Dec 11, 2015

Member

Seems that testing of this fix is my business :(
🐝 from what I see, but I'll verify it manually.

Member

oleg-nenashev commented Dec 11, 2015

Seems that testing of this fix is my business :(
🐝 from what I see, but I'll verify it manually.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Dec 11, 2015

Member

Test failure is unrelated

Member

oleg-nenashev commented Dec 11, 2015

Test failure is unrelated

@jtnord

This comment has been minimized.

Show comment
Hide comment
@jtnord

jtnord Dec 21, 2015

Member

🐝

Member

jtnord commented Dec 21, 2015

🐝

jglick added a commit that referenced this pull request Dec 21, 2015

Merge pull request #1951 from jglick/windows-service-webroot
Specify --webroot to the Windows service wrapper

@jglick jglick merged commit e84890f into jenkinsci:master Dec 21, 2015

1 check failed

Jenkins Looks like there's a problem with this pull request
Details
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Dec 22, 2015

Member

Don't forget changelogs!

Member

oleg-nenashev commented Dec 22, 2015

Don't forget changelogs!

daniel-beck added a commit that referenced this pull request Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment