[FIXED JENKINS-32844] Options under the drop-down menu at account name in the top bar doesn't work correctly when it contains a slash

[fbelzunc]

To re-produce:

1. Install a fresh Jenkins instance with latest bits
2. Install mock security realm plugin and configure it with an user containing a slash (foo/foo)
3. log-in
4. Options under the account name are not displayed and when clicking in the user link you get a HTTP ERROR 404.

https://issues.jenkins-ci.org/browse/JENKINS-32844

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[daniel-beck]

Looks like a legitimate test failure.

[oleg-nenashev]

@fbelzunc
I doubt this fix resolves all issues with users having slashes. I doubt we really want to support this use-case. Is there any realistic use-case of slashes in user names

[fbelzunc]

@daniel-beck Right, my fault for not checking the test on mi side before submitting the pull request. Sorry for your time.

@oleg-nenashev Answering you in-line:

I doubt this fix resolves all issues with users having slashes.

Right, nobody is saying the opposite. I am trying to fix what is explained in JENKINS-32844.

I doubt we really want to support this use-case.

Well, this is something I let the community to decide. My understanding is that as long as RFC 2253 allows forward slash Jenkins should manage this use-case as well.

Is there any realistic use-case of slashes in user names

As long as it is a possibility per RFC 2253 I guess it might be a real use case.

[daniel-beck]

@fbelzunc No problem, just FYI this isn't a false positive test failure, but needs fixing.

[fbelzunc]

@daniel-beck all those tests pass successfully on my laptop. I am closing and re-opening the pull request to re-build

[jtnord]

Windows usernames will very likely contain a backslash in a multi domain environment DOMAIN1\User and DOMAIN2\User are different users.

[tfennelly]

@fbelzunc What are we expecting to happen with this change? Does "me" resolve to something special on the server-side?

[jtnord]

🐛 the url is just ${rootURL}/me

[jtnord]

🐛 the url to the current users stuff is just ${rootURL}/me not ${rootURL}/users/me which would actually be the user with the id of "me"

[fbelzunc]

@daniel-beck @jtnord Now, this is working correctly.

[armfergom]

LGTM 🐝

[fbelzunc]

Squashing to have only 1 commit for cleaning merger purposes

[jtnord]

@felix - this is only a partial fix. How are users going to get to see other users configurations?

[fbelzunc]

@jtnord

• this is only a partial fix. How are users going to get to see other users configurations?

You are right - it is only a partial fix. Here, I am only trying to fix JENKINS-32844: Options under the drop-down menu at account name in the top bar doesn't work correctly when it contains a slash. Notice, that some of the options on the dropdown menu are also available on the left-menu and they carry you to /me, that's why I think there is nothing wrong with this pull request.

I agree that the "real" fix requires some investigation and time ;-)

[jtnord]

@fbelzunc well when I tested this later on when you hit configure etc things don't work so you are unable to do much with this fix :-/

[fbelzunc]

Closing this PR