[FIX JENKINS-33127] BootFailures send HTTP 500

[daniel-beck]

HTTP 500 is used for oops.jelly, so it seemed the most appropriate for the various BootFailures as well.

Untested, which in the case of JenkinsReloadFailed/index.groovy could be a problem (nowhere to copy&paste from). If someone knows how to trigger this one, please let me know.

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[KostyaSha]

👍

[aheritier]

🐝 the build error isn't related to your PR, master is also broken : https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/4026/console

[jglick]

Please merge with master.

[jglick]

I think BootFailure should get a default index.jelly which includes a details.jelly view, the default version of which would simply ${h.printThrowable(it.cause)}. Then we would not need to have so much duplicated boilerplate.

[jglick]

Anyway, 🐝

[aheritier]

@jglick I imagine that the best to do for @daniel-beck is to rebase it on top of the current master to have the build fixed ? Is it what you mean by merge with master ?

[jglick]

Rebasing is evil. git merge master suffices.

[daniel-beck]

@jglick @aheritier Merged master.

[jglick]

🐝