Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-33467] Clarifying that CauseAction.getCauses is immutable #2129

Merged
merged 1 commit into from Mar 21, 2016

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 16, 2016

Amends #2114.

@reviewbybees

…d you should construct the action with the causes you want.
@kzantow
Copy link
Contributor

kzantow commented Mar 16, 2016

🐝

@ghost
Copy link

ghost commented Mar 16, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@armfergom
Copy link

🐝

@jglick
Copy link
Member Author

jglick commented Mar 16, 2016

@reviewbybees done

@ghost
Copy link

ghost commented Mar 16, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@oleg-nenashev
Copy link
Member

LGTM

@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Mar 17, 2016
jglick added a commit that referenced this pull request Mar 21, 2016
[JENKINS-33467] Clarifying that CauseAction.getCauses is immutable
@jglick jglick merged commit a5124b5 into jenkinsci:master Mar 21, 2016
@jglick jglick deleted the immutable-list-JENKINS-33467 branch March 21, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-reviews Complex change, which would benefit from more eyes
Projects
None yet
4 participants