Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED ENKINS-33601] Change 'Skip' text in setup wizard #2213

Merged
merged 1 commit into from Apr 5, 2016
Merged

[FIXED ENKINS-33601] Change 'Skip' text in setup wizard #2213

merged 1 commit into from Apr 5, 2016

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Apr 4, 2016

Change the label from 'Skip' to 'Continue as admin', for clarity, which is actually what happens if you don't create an alternate first admin user during the setup wizard.

image

This addresses: https://issues.jenkins-ci.org/browse/JENKINS-33601

@reviewbybees

@ghost
Copy link

ghost commented Apr 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev
Copy link
Member

Better that the current state, hence 🐝
Maybe makes sense to notice that the default password is still available for users

@kzantow
Copy link
Contributor Author

kzantow commented Apr 4, 2016

@oleg-nenashev the next page displays a warning message indicating they can use the same password used when running the setup wizard. the hope is they create a new user instead or proceed to immediately go configure security differently.

@batmat
Copy link
Member

batmat commented Apr 4, 2016

👍

@mslusarczyk
Copy link
Contributor

🐝

@kzantow
Copy link
Contributor Author

kzantow commented Apr 4, 2016

@reviewbybees done - only waiting for feedback from @daniel-beck

@daniel-beck daniel-beck merged commit f2ba3b9 into jenkinsci:2.0 Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants