Use DirectoryStream paths in java 7 to traverse the users. #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move to Java 7 the nio2 library is made available for usage. The DirectoryStream api allows for a more effeicient method of walking the directory tree structure. This fixes a potential performance issue where there are several thousand users in the $JENKINS_HOME/users directory which are still on the legacy format for user ids. This uses the NIO2 methods for doing the tree walk and moving the directories into the correct locations.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
christ66
added
the
needs-more-reviews
| new Object[]{legacyUserDir, configFile.getParentFile()}); | ||
|
|
||
| try { | ||
| DirectoryStream<Path> legacy = getLegacyConfigFilesFor(id); |
There was a problem hiding this comment.
🐛 legacy is not closed. Use try-with-resources.
christ66
added
work-in-progress
|
I think the failing unit test is part of these code changes. Marking as WIP. |
|
What is the motivation behind this change? The code in question is only ever run once, during an upgrade from an old Jenkins version. Do we really care about optimizing it? |
|
@jglick I've seen this triggered via the api (with the git plugin). |
oleg-nenashev
added
the
unresolved-merge-conflict
|
JENKINS-47429 seems to track this issue. |
|
Obsolete as of #3150. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to Java 7 the nio2 library is made available for usage. The DirectoryStream api allows for a more effeicient method of walking the directory tree structure. This fixes a potential performance issue where there are several thousand users in the $JENKINS_HOME/users directory which are still on the legacy format for user ids. This uses the NIO2 methods for doing the tree walk and moving the directories into the correct locations.
@reviewbybees