Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest version #2274

Closed
wants to merge 1 commit into from
Closed

Use the latest version #2274

wants to merge 1 commit into from

Conversation

kohsuke
Copy link
Member

@kohsuke kohsuke commented Apr 19, 2016

In particular, this will install Java7 when build agents don't have any
Java. 1.9 tries to install Java6 which is no good.

In particular, this will install Java7 when build agents don't have any
Java. 1.9 tries to install Java6 which is no good.
@jtnord
Copy link
Member

jtnord commented Apr 19, 2016

why install 1.7, whilst it is the minimum supported it is old, unpatched and very possibly filled with security holes.

Given we are trying to be secure by default this seems like a backward step, and many people may not be java shops and aware of any issues. (yes we are not really running the salve as a "service" and exposing ports for attacks, but at the same time...)

@jtnord
Copy link
Member

jtnord commented Apr 19, 2016

🐝 I think - but upgrading detached plugins seems a little screwy, its only for very old upgrades (running a version of jenkins prior to when the plugin was first detached) and an upgrade can (and should) be upgrading plugins - not sure why the upgrade wizard[1] doesn't resolve a newer version of the plugin if it is available from the UC...

[1] does it exist yet?

@daniel-beck
Copy link
Member

👎 This is irrelevant in Jenkins 2.x, as the setup will always install the newest release. And this plugin doesn't even qualify for the core detachment compatibility code, so it could be removed altogether.

@tfennelly Or is there a reason this is still around? It never was part of core, therefore never detached, therefore will never be installed, right?

@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label May 3, 2016
@oleg-nenashev
Copy link
Member

seems it's not required anymore

@tfennelly
Copy link
Member

I'm fairly sure that this change will only effect the test harness.

@daniel-beck
Copy link
Member

Filed JENKINS-34583. Closing this.

@daniel-beck daniel-beck closed this May 3, 2016
@oleg-nenashev oleg-nenashev deleted the ssh-slaves-1.10 branch June 9, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-reviews Complex change, which would benefit from more eyes
Projects
None yet
5 participants