Force ordering between GPG and jarsigner #2285

Merged
merged 1 commit into from Apr 26, 2016

Conversation

3 participants
@kohsuke
Member

kohsuke commented Apr 22, 2016

jarsigner adds signatures by updating the file itself, so we have
to run it before GPG plugin signs the bit, which happens in the 'verify'
phase.

The 'pre-integration-test' phase happens right after the 'package'
phase and before the 'verify' phase, so this is adequate.

See: https://groups.google.com/forum/#!msg/jenkinsci-users/POk8TOcwOM8/i5wn2a0MMwAJ

Force ordering between GPG and jarsigner
jarsigner adds signatures by updating the file itself, so we have
to run it before GPG plugin signs the bit, which happens in the 'verify'
phase.

The 'pre-integration-test' phase happens right after the 'package'
phase and before the 'verify' phase, so this is adequate.

See: https://groups.google.com/forum/#!msg/jenkinsci-users/POk8TOcwOM8/i5wn2a0MMwAJ
@Vlatombe

This comment has been minimized.

Show comment
Hide comment
@Vlatombe

Vlatombe Apr 23, 2016

Member

LGTM. You could even use 'package' phase as executions bound through the pom are executed after executions from the lifecycle.

Member

Vlatombe commented Apr 23, 2016

LGTM. You could even use 'package' phase as executions bound through the pom are executed after executions from the lifecycle.

@recena

This comment has been minimized.

Show comment
Hide comment
@recena

recena Apr 23, 2016

Contributor

@kohsuke Why not in prepare-package or as @Vlatombe mentions, in package?

Contributor

recena commented Apr 23, 2016

@kohsuke Why not in prepare-package or as @Vlatombe mentions, in package?

@Vlatombe

This comment has been minimized.

Show comment
Hide comment
@Vlatombe

Vlatombe Apr 23, 2016

Member

@recena the .war doesn't exist yet in prepare-package.

Member

Vlatombe commented Apr 23, 2016

@recena the .war doesn't exist yet in prepare-package.

@recena

This comment has been minimized.

Show comment
Hide comment
@recena

recena Apr 23, 2016

Contributor

@Vlatombe Ups, It is true. I did not keep in mind that we need to sign the war file ...

Contributor

recena commented Apr 23, 2016

@Vlatombe Ups, It is true. I did not keep in mind that we need to sign the war file ...

@kohsuke kohsuke merged commit 8356bd4 into master Apr 26, 2016

1 check passed

Jenkins This pull request looks good
Details

@kohsuke kohsuke deleted the jarsigner-and-gpg branch Apr 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment