Force ordering between GPG and jarsigner #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarsigner adds signatures by updating the file itself, so we have to run it before GPG plugin signs the bit, which happens in the 'verify' phase. The 'pre-integration-test' phase happens right after the 'package' phase and before the 'verify' phase, so this is adequate. See: https://groups.google.com/forum/#!msg/jenkinsci-users/POk8TOcwOM8/i5wn2a0MMwAJ
|
LGTM. You could even use 'package' phase as executions bound through the pom are executed after executions from the lifecycle. |
|
@recena the .war doesn't exist yet in |
|
@Vlatombe Ups, It is true. I did not keep in mind that we need to sign the war file ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jarsigner adds signatures by updating the file itself, so we have
to run it before GPG plugin signs the bit, which happens in the 'verify'
phase.
The 'pre-integration-test' phase happens right after the 'package'
phase and before the 'verify' phase, so this is adequate.
See: https://groups.google.com/forum/#!msg/jenkinsci-users/POk8TOcwOM8/i5wn2a0MMwAJ