Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol annotations on core #2293

Merged
merged 26 commits into from May 4, 2016
Merged

Symbol annotations on core #2293

merged 26 commits into from May 4, 2016

Commits on Mar 12, 2016

  1. make the first view primary if none is chosen 

    ... but some views already exist.
    @kohsuke
    kohsuke committed Mar 12, 2016
    Configuration menu
    Copy the full SHA
    a95ac5e View commit details
    Browse the repository at this point in the history

  2. Assigning some symbol names to use them

    @kohsuke
    kohsuke committed Mar 12, 2016
    Configuration menu
    Copy the full SHA
    16c4b50 View commit details
    Browse the repository at this point in the history

  3. More symbol assignments and constructor diet 

    to move more properties off to setters.
    @kohsuke
    kohsuke committed Mar 12, 2016
    Configuration menu
    Copy the full SHA
    3e842b6 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2016

  1. More @symbol annotations to test this out

    @kohsuke
    kohsuke committed Mar 14, 2016
    Configuration menu
    Copy the full SHA
    0ea11ef View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2016

  1. @extension on static field is not kosher

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    e6254e1 View commit details
    Browse the repository at this point in the history

  2. Adding @symbol 

    Where applicable symbol names used by Job DSL plugin is used for maximum compatibility: https://jenkinsci.github.io/job-dsl-plugin/
    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    3d43901 View commit details
    Browse the repository at this point in the history

  3. fixup field descriptor

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    1941a55 View commit details
    Browse the repository at this point in the history

  4. More symbols

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    26f8246 View commit details
    Browse the repository at this point in the history

  5. field descriptor fixup

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    f315e63 View commit details
    Browse the repository at this point in the history

  6. More symbol names

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    e1c4028 View commit details
    Browse the repository at this point in the history

  7. More symbols

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    ee29ef5 View commit details
    Browse the repository at this point in the history

  8. descriptor fixup

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    d3dc647 View commit details
    Browse the repository at this point in the history

  9. More symbols

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    47c880e View commit details
    Browse the repository at this point in the history

  10. Field descriptor fixup

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    d982647 View commit details
    Browse the repository at this point in the history

  11. More symbol annotations

    @kohsuke
    kohsuke committed Mar 19, 2016
    Configuration menu
    Copy the full SHA
    6330f8a View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2016

  1. Rely on a released version

    @kohsuke
    kohsuke committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    12433f0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/2.0' into symbol 

    Conflicts:
	core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java
	core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol2.java
    @kohsuke
    kohsuke committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    90ff340 View commit details
    Browse the repository at this point in the history

  3. Changing this based on James Nord's suggestion

    @kohsuke
    kohsuke committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    cabf0e9 View commit details
    Browse the repository at this point in the history

  4. This is not Describable, so no @DataBoundSetter here

    @kohsuke
    kohsuke committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    6542856 View commit details
    Browse the repository at this point in the history

  5. Renamed based on James Nord suggestion

    @kohsuke
    kohsuke committed Mar 22, 2016
    Configuration menu
    Copy the full SHA
    53be006 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2016

  1. Merge remote-tracking branch 'origin/master' into symbol 

    Conflicts:
	core/src/main/java/hudson/model/FreeStyleProject.java
	core/src/main/java/jenkins/model/GlobalConfigurationCategory.java
    @kohsuke
    kohsuke committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    6af569c View commit details
    Browse the repository at this point in the history

  2. Added consistent names matching with other ParameterDescriptors 

    ... based on comments in PR #2160
    @kohsuke
    kohsuke committed Apr 26, 2016
    2 Configuration menu
    Copy the full SHA
    f94ce3a View commit details
    Browse the repository at this point in the history

  3. Clarifying that this is not atomic and that's OK for the use case.

    @kohsuke
    kohsuke committed Apr 26, 2016
    Configuration menu
    Copy the full SHA
    137e8ce View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2016

  1. 'boolean' is a not a valid Java identifier

    @kohsuke
    kohsuke committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    2a7ed69 View commit details
    Browse the repository at this point in the history

  2. 'default' is not a valid identifier, so we need something else. 

    This is truly unfortunate because 'default' is how we call them in the
UI. My choice is between something like 'default_' vs a synonym, so I
went for 'standard'
    @kohsuke
    kohsuke committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    15c543d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2016

  1. Merge remote-tracking branch 'origin/master' into symbol

    @kohsuke
    kohsuke committed May 2, 2016
    Configuration menu
    Copy the full SHA
    92c81e6 View commit details
    Browse the repository at this point in the history