translation-tool.pl - Feature for adding unique prefix for each missing translation

[damianszczepanik]

Motivation and advantages are presented on attached screenshot. Sometimes I found hard to find where is the proper *.properties file with translation so I added feature for provided translation-tool.sh script that marks each missing translation by:

• adding TranslateMe prefix so it is easily found on the page
• unique number so developer can in a second find where is the string that should be translated

[damianszczepanik]

[oleg-nenashev]

LGTM 👍

[damianszczepanik]

@daniel-beck can you merge this change or you have some comments/questions ?

[daniel-beck]

I'm not really qualified to evaluate this change, knowing little Perl.

Besides that, LGTM, so assuming nobody else objects I suppose we can merge in a few days. It's not like it'll break Jenkins even if it doesn't work at all ;-)

[batmat]

👍 I suppose .pl stands for polish ;-)

[oleg-nenashev]

I'm not sure if it requires changelogs. Maybe this tool needs to be decoupled to a separate repo

[damianszczepanik]

I'm using this tool when adding new translations. I found eg that the order of translated keys is not the same as in original. I will try to look deeper at this and maybe prepare new patchset.

I don't think that moving to separate repo is good idea because then new developers may not be aware that there is dedicated tool that helps them with translating.

[oleg-nenashev]

@damianszczepanik Maybe a blogpost or jenkins.io article could be also helpful to highlight such tools.Maybe a subproject like https://jenkins.io/projects/infrastructure/

[daniel-beck]

@oleg-nenashev Well, it's a tool for translators, and pretty much for only them. https://wiki.jenkins-ci.org/display/JENKINS/Beginners+Guide+to+Contributing#BeginnersGuidetoContributing-DoyouspeaklanguagesotherthanEnglish%3F links to https://wiki.jenkins-ci.org/display/JENKINS/Internationalization links to https://wiki.jenkins-ci.org/display/JENKINS/Translation+Tool which is pretty much the exposure a specialized tool like this deserves.