New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKIN-20913] - Update winp to 1.24. #2619

Merged
merged 1 commit into from Nov 27, 2016

Conversation

2 participants
@oleg-nenashev
Member

oleg-nenashev commented Nov 6, 2016

In particular, it addresses issues like JENKIN-20913.

Changes to be picked

1.24

Release date: Nov 2, 2016

  • Issue #22 - Winp sometimes kills random processes when using killRecursive. (PR #23)
  • WINP-10 - Fix for getCmdLineAndEnvVars() which fails on x64 versions of Windows. (PR #20)
  • Issue #24 - Wrong folder when using the winp.folder.preferred system property (parent instead of the actual folder). (PR #25)
  • Issue #26, JENKINS-20913 - Native class now tries loading DLLs via the temp location. (PR #27)

1.23

Release date: Fev 16, 2015

  • Migrate native components to Visual Studio Community 2013. (PR #14)
  • Provide a winp.unpack.dll.to.parent.dir property, which disables DLL unpacking to the parent dir. (PR #14)

@reviewbybees, esp. @jtnord

Update winp to 1.24. In particular, it addresses issues like [JENKINS…
…-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913)

### Changes to be picked

### 1.24

Release date: Nov 2, 2016

* [Issue #22](kohsuke/winp#22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](kohsuke/winp#23))
* [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](kohsuke/winp#20))
* [Issue #24](kohsuke/winp#24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](kohsuke/winp#25))
* [Issue #26](kohsuke/winp#26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](kohsuke/winp#27))

### 1.23

Release date: Fev 16, 2015

* Migrate native components to Visual Studio Community 2013. ([PR #14](kohsuke/winp#14))
* Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](kohsuke/winp#12))
@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Nov 6, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Nov 7, 2016

Member

Tests have passed, but obviously it requires some manual testing on Windows

Member

oleg-nenashev commented Nov 7, 2016

Tests have passed, but obviously it requires some manual testing on Windows

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Nov 7, 2016

Member

Putting it on hold till the new LTS line gets selected, high risk of regressions we cannot catch by automatic test suites

Member

oleg-nenashev commented Nov 7, 2016

Putting it on hold till the new LTS line gets selected, high risk of regressions we cannot catch by automatic test suites

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment

@oleg-nenashev oleg-nenashev removed the on-hold label Nov 27, 2016

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Nov 27, 2016

Member

@reviewbybees done (1 week timeout)
Merging since there is no negative feedback and since @daniel-beck proposed merging it in IRC. I will monitor the fallout if it happens

Member

oleg-nenashev commented Nov 27, 2016

@reviewbybees done (1 week timeout)
Merging since there is no negative feedback and since @daniel-beck proposed merging it in IRC. I will monitor the fallout if it happens

@oleg-nenashev oleg-nenashev merged commit 63c2f6c into jenkinsci:master Nov 27, 2016

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

oleg-nenashev added a commit that referenced this pull request Nov 27, 2016

olivergondza added a commit that referenced this pull request Dec 6, 2016

Update winp to 1.24. In particular, it addresses issues like [JENKINS…
…-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) (#2619)

### Changes to be picked

### 1.24

Release date: Nov 2, 2016

* [Issue #22](kohsuke/winp#22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](kohsuke/winp#23))
* [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](kohsuke/winp#20))
* [Issue #24](kohsuke/winp#24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](kohsuke/winp#25))
* [Issue #26](kohsuke/winp#26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](kohsuke/winp#27))

### 1.23

Release date: Fev 16, 2015

* Migrate native components to Visual Studio Community 2013. ([PR #14](kohsuke/winp#14))
* Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](kohsuke/winp#12))
(cherry picked from commit 63c2f6c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment