Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39741] - Redirect to login page after authorisation error when checking connectivity to update center and handle any other error. #2636

Merged
merged 1 commit into from Nov 19, 2016

Conversation

alvarolobato
Copy link
Member

…en checking connectivity to update center and handle any other error.
@ghost
Copy link

ghost commented Nov 15, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@amuniz
Copy link
Member

amuniz commented Nov 15, 2016

🐝

@oleg-nenashev
Copy link
Member

Would be nice to see a test for this case. Installation wizard stays an area with a poor coverage.
🐝 for the change itself

@oleg-nenashev oleg-nenashev added the needs-more-reviews Complex change, which would benefit from more eyes label Nov 15, 2016
@alvarolobato
Copy link
Member Author

@reviewbybees done

@ghost
Copy link

ghost commented Nov 16, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@daniel-beck daniel-beck merged commit 7f25524 into jenkinsci:master Nov 19, 2016
oleg-nenashev added a commit that referenced this pull request Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-reviews Complex change, which would benefit from more eyes
Projects
None yet
4 participants