[FIX JENKINS-39700] Don't fail when no parameters property for job #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
added
needs-more-reviews
|
I'm not sure it's a good approach to just delete the code. Maybe the private method should just check existence of the Object and do nothing if it is missing |
|
@oleg-nenashev What's the point? As JENKINS-33991 describes, at least Freestyle jobs don't hit that check anyway. |
daniel-beck
removed
the
work-in-progress
|
@jenkinsci/code-reviewers |
|
If this is a dead code for freestyles, 👍 from me. |
oleg-nenashev
approved these changes
Dec 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely fallout from
OptionalJobPropertyintroduction in 1.637 (!) a year ago. External monitor job sure is popular.@jglick says in JENKINS-33991 that there's no guarantee that a
ParametersDefinitionPropertyif present also has at least one parameter, so just rip out this likely obsolete check.