[FIX JENKINS-26977] Use project-specific check URL #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
added
the
needs-more-reviews
jtnord
reviewed
Jan 30, 2017
| @@ -25,7 +25,7 @@ THE SOFTWARE. | |||
| <?jelly escape-by-default='true'?> | |||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form"> | |||
| <f:entry title="${%Schedule}" help="/descriptor/hudson.triggers.TimerTrigger/help/spec"> | |||
| <f:textarea field="scmpoll_spec" checkUrl="'${rootURL}/trigger/TimerTrigger/check?value='+encodeURIComponent(this.value)"/> | |||
| <f:textarea field="scmpoll_spec" checkUrl="'descriptorByName/hudson.triggers.TimerTrigger/checkSpec?value='+encodeURIComponent(this.value)"/> | |||
There was a problem hiding this comment.
does this not need to be /descriptorByName or use the ${rootUrl}/descriptorByName
For jobs in folders - I would expect this to be currently be an incrrect URL leading to a 404.
There was a problem hiding this comment.
@jtnord This calls http://javadoc.jenkins-ci.org/hudson/model/AbstractItem.html#getDescriptorByName%28java.lang.String%29 and it needs to for the H pattern in cron expressions, which are project specific and use AncestorInPath:
Otherwise, no way to resolve this issue of incorrect predictions in the 'success' case.
jtnord
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether this would lead to weird interactions though.
@jenkinsci/code-reviewers and especially @jglick PTAL