Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-48383] Add loggedIn event on self-registration #3175

Merged
merged 1 commit into from
Dec 12, 2017
Merged

[JENKINS-48383] Add loggedIn event on self-registration #3175

merged 1 commit into from
Dec 12, 2017

Conversation

Wadeck
Copy link
Contributor

@Wadeck Wadeck commented Dec 5, 2017

  • when the user self-register an account, he is logged in automatically after
  • also when there is no user and we create the first account (using Setup Wizard)

See JENKINS-48383.

Proposed changelog entries

  • Trigger loggedIn event on self-registration (first user and also next ones), when using HudsonPrivateSecurityRealm

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests

Desired reviewers

@reviewbybees

@Wadeck Wadeck added the needs-more-reviews Complex change, which would benefit from more eyes label Dec 5, 2017
@jglick
Copy link
Member

jglick commented Dec 6, 2017

@reviewbybees done

oleg-nenashev
oleg-nenashev approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 and 👍

@oleg-nenashev oleg-nenashev added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-more-reviews Complex change, which would benefit from more eyes labels Dec 7, 2017
@oleg-nenashev
Copy link
Member

Test failures are not related from what I see

@oleg-nenashev
Copy link
Member

Retriggering CI just in case

@oleg-nenashev oleg-nenashev reopened this Dec 10, 2017
@oleg-nenashev oleg-nenashev reopened this Dec 10, 2017
@oleg-nenashev
Copy link
Member

The issue with org.jvnet.hudson.test.BuildTriggerTest seems to be consistent. I am pretty sure it's unrelated, but's wait before merging

@daniel-beck
Copy link
Member

@oleg-nenashev testSomething is the fake test that made Jesse file #3168

@oleg-nenashev
Copy link
Member

🚢 🇮🇹 then

@oleg-nenashev oleg-nenashev merged commit cc6c508 into jenkinsci:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wadeck @jglick @oleg-nenashev @daniel-beck