[JENKINS-48831] New/fixed version of js-lib core-asset modules #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
added
needs-more-reviews
jglick
removed
the
work-in-progress
|
Not a werk-in-progress merely because it might need snapshot dependency updates; that is something that can be done by a merger. |
jglick
reviewed
Jan 8, 2018
war/pom.xml
Outdated
| @@ -41,6 +41,7 @@ THE SOFTWARE. | |||
| <JENKINS_HOME>${basedir}/work</JENKINS_HOME> | |||
| <contextPath>/jenkins</contextPath><!-- context path during test --> | |||
| <port>8080</port><!-- HTTP listener port --> | |||
| <js.libs.version>2.0.0-SNAPSHOT</js.libs.version> | |||
There was a problem hiding this comment.
Suggest js-libs.version to match repo name.
daniel-beck
added
the
on-hold
|
On-holding until upstream release. |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@tfennelly Do you plan to finish this? I think there's no release of the dependency yet? |
oleg-nenashev
requested changes
Jan 28, 2019
| @@ -41,6 +41,7 @@ THE SOFTWARE. | |||
| <JENKINS_HOME>${basedir}/work</JENKINS_HOME> | |||
| <contextPath>/jenkins</contextPath><!-- context path during test --> | |||
| <port>8080</port><!-- HTTP listener port --> | |||
| <js-libs.version>2.0.0-SNAPSHOT</js-libs.version> | |||
There was a problem hiding this comment.
It has not been released so far
oleg-nenashev
added
the
stalled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-48831.
Depends on jenkinsci/js-libs#4
@jenkinsci/code-reviewers @reviewbybees