Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for time days #3693

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Oct 18, 2018

Proposed changelog entries

  • Entry 1: Localization, time unit for day

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/chinese-localization-sig

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely does not make it worse. IIUC these localization files will stay in the core for a while

@oleg-nenashev oleg-nenashev merged commit 6b84d7a into jenkinsci:master Oct 18, 2018
@LinuxSuRen LinuxSuRen deleted the localization-time-day branch October 19, 2018 00:26
@LinuxSuRen
Copy link
Member Author

Yes, I still working on Java Source Localization. It's hard to migrate these and do not any change the base code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants