Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47458] update trilead-ssh2 version #3827

Merged
merged 1 commit into from Jan 2, 2019

Conversation

kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Dec 28, 2018

See :

This PR update the trilead-ssh2 due to a couple of bug fixed and a new encryption type supported

Proposed changelog entries

  • Check for null in Connection#getReasonClosedCause().
  • Print the SCP response code under failure..
  • Support OpenSSH keys with AES256-CTR encryption.
  • Wait for a timeout time if the packets have 0 size
  • Ensure logger is assigned.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Relevant PRs

@oleg-nenashev @MarkEWaite

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed with the build from the CI job that an ed25519 private key generated on Debian Buster is correctly used as an agent. Thanks for doing this!

@batmat
Copy link
Member

batmat commented Dec 28, 2018

@oleg-nenashev oleg-nenashev merged commit 7eae00a into jenkinsci:master Jan 2, 2019
@TobiX
Copy link
Contributor

TobiX commented Jan 14, 2019

FTR, "Support OpenSSH keys with AES256-CTR encryption." mentions the wrong ticket. The correct one is JENKINS-55133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants