Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47458] - Check for null in Connection#getReasonClosedCause() #25

Merged
merged 1 commit into from Sep 17, 2018

Conversation

oleg-nenashev
Copy link
Member

Just caught it in SSH Slaves plugin tests on my local machine: https://issues.jenkins-ci.org/browse/JENKINS-47458

Not sure whether null is valid though

@reviewbybees @paladox @mc1arke

@ghost
Copy link

ghost commented Oct 16, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the CI build please: add Jenkinsfile and disable old job.

@oleg-nenashev
Copy link
Member Author

For now fixed the Java version in the current CI setup

@oleg-nenashev
Copy link
Member Author

@paladox @mc1arke any plans regarding the new release?

@paladox
Copy link
Contributor

paladox commented Dec 13, 2017

@oleg-nenashev hi, not sure as @mc1arke has the merge rights :)

@oleg-nenashev
Copy link
Member Author

@mc1arke gentle ping

@oleg-nenashev
Copy link
Member Author

@reviewbybees done

@oleg-nenashev
Copy link
Member Author

@paladox @mc1arke FYI there is a query from @kuisathaverat : https://groups.google.com/forum/#!topic/jenkinsci-dev/z-uIydVxqMM . Maybe he could help with delivering bits there

@kuisathaverat
Copy link
Contributor

I will try to take a look at it this week

@kuisathaverat kuisathaverat merged commit dce2108 into jenkinsci:master Sep 17, 2018
@oleg-nenashev
Copy link
Member Author

@kuisathaverat do you plan to update the versions in the Jenkins core at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants