-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-56477] Fix to allow selecting compatible-only updates for plugins #3985
[JENKINS-56477] Fix to allow selecting compatible-only updates for plugins #3985
Commits on Apr 14, 2019
-
[JENKINS-56477] New "isCompatible" method avoiding all plugins w/ warns
Previous version was only checking "isCompatibleWithInstalledVersion", but there were several other cases that had to be checked
Configuration menu - View commit details
-
Copy full SHA for 9e1e604 - Browse repository at this point
Copy the full SHA 9e1e604View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59af705 - Browse repository at this point
Copy the full SHA 59af705View commit details -
[JENKINS-56477] Factored out getUpdateSite, init method used by 2 tests
Also removed the "sites" list from the init, since it seemed it was not being used, only using the specific site created from the external json
Configuration menu - View commit details
-
Copy full SHA for ac18b11 - Browse repository at this point
Copy the full SHA ac18b11View commit details -
[JENKINS-56477] Added a new option for plugin selection: "compatible"
Now users can select "All", "Compatible" or "None"
Configuration menu - View commit details
-
Copy full SHA for e0057ef - Browse repository at this point
Copy the full SHA e0057efView commit details -
[JENKINS-56477] checkPluginsWithoutWarnings also unchecks now
Useful if the user first clicks "Select All" and now wants to "Select Compatible" only.
Configuration menu - View commit details
-
Copy full SHA for ecddb65 - Browse repository at this point
Copy the full SHA ecddb65View commit details -
[JENKINS-56477] Added unit test for "UpdateSite.Plugin.isCompatible"
The UpdateSite class and its internal classes (e.g. Plugin) are a bit tricky to unit-test. Using some stubs to set the necessary context for the test to run
Configuration menu - View commit details
-
Copy full SHA for 5fcb95d - Browse repository at this point
Copy the full SHA 5fcb95dView commit details -
[JENKINS-56477] "mock-maker-inline" incompatible w/ other tests
Had to remove the unit test checking "pluginUpdateNotCompatible. It needed "mock-maker-inline" config to mock/spy the Plugin class (which is final), but that mockito config caused conflicts with pre-existing tests.
Configuration menu - View commit details
-
Copy full SHA for d770f15 - Browse repository at this point
Copy the full SHA d770f15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3369319 - Browse repository at this point
Copy the full SHA 3369319View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1baf41 - Browse repository at this point
Copy the full SHA c1baf41View commit details
Commits on Apr 15, 2019
-
[JENKINS-56477] Javadoc for isCompatible(). Overloaded ver. restricted
Also switched the call in table.jelly to the overloaded version of isCompatible, since a "cache" var was available in the context (and was being already used by calls to the internal methods to show the warnings)
Configuration menu - View commit details
-
Copy full SHA for 6f1330e - Browse repository at this point
Copy the full SHA 6f1330eView commit details -
Trivial change to force re-execution of pipeline.
Configuration menu - View commit details
-
Copy full SHA for ef16d59 - Browse repository at this point
Copy the full SHA ef16d59View commit details
Commits on Apr 21, 2019
-
[JENKINS-56477] "isCompatible" set to @restricted for now
This method is currently only being used by the Jenkins UI, so we are not being exposing it to plugins nor exporting it. If in the future that need emerges, this can be changed
Configuration menu - View commit details
-
Copy full SHA for af31771 - Browse repository at this point
Copy the full SHA af31771View commit details