Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-56477] Fix to allow selecting compatible-only updates for plugins #3985

Merged
merged 12 commits into from
Apr 26, 2019

Commits on Apr 14, 2019

  1. [JENKINS-56477] New "isCompatible" method avoiding all plugins w/ warns

    Previous version was only checking "isCompatibleWithInstalledVersion", but there were several other cases that had to be checked
    romenrg committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    9e1e604 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59af705 View commit details
    Browse the repository at this point in the history
  3. [JENKINS-56477] Factored out getUpdateSite, init method used by 2 tests

    Also removed the "sites" list from the init, since it seemed it was not being used, only using the specific site created from the external json
    romenrg committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    ac18b11 View commit details
    Browse the repository at this point in the history
  4. [JENKINS-56477] Added a new option for plugin selection: "compatible"

    Now users can select "All", "Compatible" or "None"
    romenrg committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    e0057ef View commit details
    Browse the repository at this point in the history
  5. [JENKINS-56477] checkPluginsWithoutWarnings also unchecks now

    Useful if the user first clicks "Select All" and now wants to "Select Compatible" only.
    romenrg committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    ecddb65 View commit details
    Browse the repository at this point in the history
  6. [JENKINS-56477] Added unit test for "UpdateSite.Plugin.isCompatible"

    The UpdateSite class and its internal classes (e.g. Plugin) are a bit tricky to unit-test. Using some stubs to set the necessary context for the test to run
    romenrg committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    5fcb95d View commit details
    Browse the repository at this point in the history
  7. [JENKINS-56477] "mock-maker-inline" incompatible w/ other tests

    Had to remove the unit test checking "pluginUpdateNotCompatible. It needed "mock-maker-inline" config to mock/spy the Plugin class (which is final), but that mockito config caused conflicts with pre-existing tests.
    romenrg committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    d770f15 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3369319 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c1baf41 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. [JENKINS-56477] Javadoc for isCompatible(). Overloaded ver. restricted

    Also switched the call in table.jelly to the overloaded version of isCompatible, since a "cache" var was available in the context (and was being already used by calls to the internal methods to show the warnings)
    romenrg committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    6f1330e View commit details
    Browse the repository at this point in the history
  2. Removed empty line.

    Trivial change to force re-execution of pipeline.
    romenrg committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    ef16d59 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2019

  1. [JENKINS-56477] "isCompatible" set to @restricted for now

    This method is currently only being used by the Jenkins UI, so we are not being exposing it to plugins nor exporting it. If in the future that need emerges, this can be changed
    romenrg committed Apr 21, 2019
    Configuration menu
    Copy the full SHA
    af31771 View commit details
    Browse the repository at this point in the history