[JENKINS-56477] Fix to allow selecting compatible-only updates for plugins

core/src/main/java/hudson/model/UpdateSite.java

@@ -1043,6 +1043,24 @@ public PluginWrapper getInstalled() {
             return pm.getPlugin(name);
         }
 
+        /**
+         * Returns true if the plugin and its dependencies are fully compatible with the current installation
+         * This is set to restricted for now, since it is only being used by Jenkins UI at the moment.
+         *
+         * @since TODO
+         */
+        @Restricted(NoExternalUse.class)
+        public boolean isCompatible() {
+            return isCompatible(new PluginManager.MetadataCache());
+        }
+
+        @Restricted(NoExternalUse.class) // table.jelly
+        public boolean isCompatible(PluginManager.MetadataCache cache) {
+            return isCompatibleWithInstalledVersion() && !isForNewerHudson() &&  !isForNewerJava() &&
+                    isNeededDependenciesCompatibleWithInstalledVersion(cache) &&
+                    !isNeededDependenciesForNewerJenkins(cache) && !isNeededDependenciesForNewerJava();
+        }
+
         /**
          * If the plugin is already installed, and the new version of the plugin has a "compatibleSinceVersion"
          * value (i.e., it's only directly compatible with that version or later), this will check to

core/src/main/resources/hudson/PluginManager/_table.js

@@ -2,8 +2,8 @@ function checkPluginsWithoutWarnings() {
     var inputs = document.getElementsByTagName('input');
     for(var i = 0; i < inputs.length; i++) {
         var candidate = inputs[i];
-        if(candidate.type === "checkbox" && candidate.dataset.compatWarning === 'false') {
-            candidate.checked = true;
+        if(candidate.type === "checkbox") {
+            candidate.checked = candidate.dataset.compatWarning === 'false';
         }
     }
 }

core/src/main/resources/hudson/PluginManager/index.jelly

@@ -29,7 +29,9 @@ THE SOFTWARE.
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
   <local:table page="updates" list="${app.updateCenter.updates}" xmlns:local="/hudson/PluginManager">
     <div style="margin-top:1em">
-      ${%Select}: <a href="javascript:checkPluginsWithoutWarnings();">${%All}</a>, <a href="javascript:toggleCheckboxes(false);">${%None}</a><br/>
+      ${%Select}: <a href="javascript:toggleCheckboxes(true);">${%All}</a>,
+                  <a href="javascript:checkPluginsWithoutWarnings();">${%Compatible}</a>,
+                  <a href="javascript:toggleCheckboxes(false);">${%None}</a><br/>
       ${%UpdatePageDescription}
       <j:if test="${!empty(app.updateCenter.jobs)}">
         <br/> ${%UpdatePageLegend(rootURL+'/updateCenter/')}

core/src/main/resources/hudson/PluginManager/table.jelly

@@ -92,7 +92,7 @@ THE SOFTWARE.
                       <input type="checkbox" name="plugin.${p.name}.${p.sourceId}"
                              checked="${installedOk ? 'checked' : null}"
                              disabled="${installedOk ? 'disabled' : null}" onClick="flip(this);"
-                             data-compat-warning="${!p.isCompatibleWithInstalledVersion()}" />
+                             data-compat-warning="${!p.isCompatible(cache)}" />
                     </td>
                     <td class="pane" data="${h.xmlEscape(p.displayName)}" data-id="${h.xmlEscape(p.name+':'+p.version)}">
                       <div>

test/src/test/java/hudson/model/UpdateSiteTest.java

@@ -45,7 +45,6 @@
 import jenkins.security.UpdateSiteWarningsConfiguration;
 import jenkins.security.UpdateSiteWarningsMonitor;
 import org.apache.commons.io.FileUtils;
-import org.eclipse.jetty.server.HttpConnection;
 import org.eclipse.jetty.server.Request;
 import org.eclipse.jetty.server.Server;
 import org.eclipse.jetty.server.ServerConnector;
@@ -56,7 +55,6 @@
 import org.junit.Test;
 import org.jvnet.hudson.test.Issue;
 import org.jvnet.hudson.test.JenkinsRule;
-import org.jvnet.hudson.test.recipes.LocalData;
 
 public class UpdateSiteTest {
 
@@ -153,16 +151,20 @@ public void shutdownWebserver() throws Exception {
         assertNotEquals("plugin data is present", Collections.emptyMap(), site.getData().plugins);
     }
 
+    @Issue("JENKINS-56477")
+    @Test
+    public void isPluginUpdateCompatible() throws Exception {
+        UpdateSite site = getUpdateSite("/plugins/minJavaVersion-update-center.json");
+        final UpdateSite.Plugin tasksPlugin = site.getPlugin("tasks");
+        assertNotNull(tasksPlugin);
+        assertFalse(tasksPlugin.isNeededDependenciesForNewerJava());
+        assertFalse(tasksPlugin.isForNewerJava());
+        assertTrue(tasksPlugin.isCompatible());
+    }
+
     @Issue("JENKINS-55048")
     @Test public void minimumJavaVersion() throws Exception {
-        // TODO: factor out the sites init
-        PersistedList<UpdateSite> sites = j.jenkins.getUpdateCenter().getSites();
-        sites.clear();
-        URL url = new URL(baseUrl, "/plugins/minJavaVersion-update-center.json");
-        UpdateSite site = new UpdateSite(UpdateCenter.ID_DEFAULT, url.toString());
-        sites.add(site);
-        assertEquals(FormValidation.ok(), site.updateDirectly(false).get());
-        // END TODO
+        UpdateSite site = getUpdateSite("/plugins/minJavaVersion-update-center.json");
 
         final UpdateSite.Plugin tasksPlugin = site.getPlugin("tasks");
         assertNotNull(tasksPlugin);
@@ -187,4 +189,12 @@ public void shutdownWebserver() throws Exception {
         assertTrue("isLegacyDefault should be true when url is http://updates.hudson-labs.org/",new UpdateSite("dummy","http://updates.hudson-labs.org/").isLegacyDefault());
         assertFalse("isLegacyDefault should be false with null url",new UpdateSite(null,null).isLegacyDefault());
     }
+
+
+    private UpdateSite getUpdateSite(String path) throws Exception {
+        URL url = new URL(baseUrl, path);
+        UpdateSite site = new UpdateSite(UpdateCenter.ID_DEFAULT, url.toString());
+        assertEquals(FormValidation.ok(), site.updateDirectly(false).get());
+        return site;
+    }
 }