Display a warning in the Installed tab if the admin is about to disable or uninstall a detached plugin #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le or uninstall a detached plugin.
fcojfernandez
approved these changes
Jul 4, 2019
varyvol
approved these changes
Jul 4, 2019
daniel-beck
approved these changes
Jul 4, 2019
oleg-nenashev
approved these changes
Jul 4, 2019
oleg-nenashev
added
the
ready-for-merge
|
Will merge tomorrow if nobody is against |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4001 (comment) (JENKINS-33843). The warning is displayed only for a plugin which is in the detached list (whether or not it has since been upgraded, or was even installed this way to begin with); which is currently enabled (otherwise presumably it is too late); and for which there was not already an informational row about enabled mandatory dependents which would have been disabling the enablement checkbox and Uninstall button. In this example, these conditions select
matrix-authandmatrix-project:Proposed changelog entries