Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

Merged
merged 8 commits into from
Apr 19, 2020
Merged

Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c4e5234
Allow linking to pre-filtered plugin manager pages, link from labels/…
daniel-beck Mar 17, 2020
a4c456c
Add custom hyperlink styles for the category pills
fqueiruga Mar 20, 2020
3498a52
Merge pull request #3 from fqueiruga/style-category-badges
daniel-beck Mar 20, 2020
1eb4f3b
Merge branch 'master' into linkable-filter-field
daniel-beck Mar 20, 2020
a4e190f
Merge branch 'master' into linkable-filter-field
daniel-beck Apr 16, 2020
12523a5
Merge branch 'linkable-filter-field' of github.com:daniel-beck/jenkin…
daniel-beck Apr 16, 2020
dd7285d
Make this look better while the page is loading
daniel-beck Apr 16, 2020
77bdf35
Fix JS issue on tabs other than "Available"
daniel-beck Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/resources/hudson/PluginManager/_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ Behaviour.specify("#filter-box", '_table', 0, function(e) {
}

e.onkeyup = applyFilter;

(function() {
applyFilter();
}());
});

/**
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/hudson/PluginManager/installed.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ THE SOFTWARE.
<st:adjunct includes="hudson.PluginManager._table"/>
<div id="filter-container">
${%Filter}:
<input type="text" id="filter-box"/>
<input type="text" id="filter-box" value="${request.getParameter('filter')}"/>
</div>

<j:if test="${app.updateCenter.isRestartRequiredForCompletion()}">
Expand Down
6 changes: 4 additions & 2 deletions core/src/main/resources/hudson/PluginManager/table.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ THE SOFTWARE.

<div id="filter-container">
${%Filter}:
<input type="text" id="filter-box"/>
<input type="text" id="filter-box" value="${request.getParameter('filter')}"/>
</div>

<form method="post" action="install">
Expand Down Expand Up @@ -77,7 +77,9 @@ THE SOFTWARE.
<div class="plugin-manager__categories">
<j:forEach var="label" items="${p.categories}">
<span class="plugin-manager__category-label">
${app.updateCenter.getCategoryDisplayName(label)}
<a href="?filter=${app.updateCenter.getCategoryDisplayName(label)}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, love that these can be made into hyperlinks. I'd say to inspire us in bootstrap pill buttons (https://getbootstrap.com/docs/4.4/components/badge/#links) and maybe style the background and remove the text underline. I can get some styles going on if you want.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already expected something like that, but it's a waste of time for me to start on before any feedback 😆 Go for it 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, may take a few days if that's OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the on-hold label on this one, now that my changes are merged in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for the reminder @fqueiruga

${app.updateCenter.getCategoryDisplayName(label)}
</a>
</span>
</j:forEach>
</div>
Expand Down