Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

daniel-beck · 2020-03-17T01:21:06Z

I think I got some feedback on #4534 somewhere that said the tags/labels should be clickable. Now they are.

This has an interaction with #4580: That PR would show more plugins for a given nontrivial expression, as spaces are separators there, rather than part of a single search term.

Additionally, it might be confusing for users who expect a click on a label to only show plugins with the label to also get results that match the label as a search expression, because that's what this does. Thoughts?

Screenshot

See URL and filter field:

(Note that this is my update center test data from #4588, so only has plugins whose name starts with "a" or "b".)

Proposed changelog entries

Allow linking to plugin manager URLs with pre-filled filter field
Link labels in the plugin manager to pre-filtered lists

Proposed upgrade guidelines

N/A

Submitter checklist

[n/a] JIRA issue is well described
Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
- Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
Appropriate autotests or explanation to why this change has no tests
[n/a] For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

There are at least 2 approvals for the pull request and no outstanding requests for change
Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
Changelog entries in the PR title and/or Proposed changelog entries are correct
Proper changelog labels are set so that the changelog can be generated automatically
If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

…tags

fqueiruga · 2020-03-17T09:15:58Z

core/src/main/resources/hudson/PluginManager/table.jelly

@@ -77,7 +77,9 @@ THE SOFTWARE.
                        <div class="plugin-manager__categories">
                          <j:forEach var="label" items="${p.categories}">
                            <span class="plugin-manager__category-label">
-                              ${app.updateCenter.getCategoryDisplayName(label)}
+                              <a href="?filter=${app.updateCenter.getCategoryDisplayName(label)}">


Wow, love that these can be made into hyperlinks. I'd say to inspire us in bootstrap pill buttons (https://getbootstrap.com/docs/4.4/components/badge/#links) and maybe style the background and remove the text underline. I can get some styles going on if you want.

I already expected something like that, but it's a waste of time for me to start on before any feedback 😆 Go for it 👍

Will do, may take a few days if that's OK

Can we remove the on-hold label on this one, now that my changes are merged in?

Right, thanks for the reminder @fqueiruga

Add custom hyperlink styles for the category pills

timja · 2020-03-28T13:30:21Z

This seems to cause a page refresh and all plugins are shown for a couple of seconds and then the filter is applied,

a couple of possible fixs:

no page refresh?
possibly not an issue after Pre-filter the 'Available' plugin manager tab, allow multiple terms #4580 is merged?

daniel-beck · 2020-03-28T13:53:30Z

This seems to cause a page refresh and all plugins are shown for a couple of seconds and then the filter is applied

Right. Someone else can figure out how to do this via JS. Only ever a problem on the "Available" tab, and only if we reject #4580, as the others will have far fewer entries.

timja · 2020-03-28T13:55:43Z

This seems to cause a page refresh and all plugins are shown for a couple of seconds and then the filter is applied

Right. Someone else can figure out how to do this via JS. Only ever a problem on the "Available" tab, and only if we reject #4580, as the others will have far fewer entries.

Ok +1 once #4580 is merged

fqueiruga · 2020-04-13T10:39:50Z

I'm assuming this one is ready to go once the conflicts are resolved right?

timja · 2020-04-13T10:49:00Z

I'm assuming this one is ready to go once the conflicts are resolved right?

Pretty much, I would like to test it out locally though.

…s into linkable-filter-field

daniel-beck · 2020-04-16T12:34:05Z

New PR comment addition:

Additionally, it might be confusing for users who expect a click on a label to only show plugins with the label to also get results that match the label as a search expression, because that's what this does. Thoughts?

timja · 2020-04-16T13:00:19Z

This doesn't seem to be working right for me on the available tab, if I click a label it puts the query in the input and focuses it but doesn't do anything till I move the cursor or press the arrow key one to the right.

The available tab seems to be working fine

daniel-beck · 2020-04-16T13:15:33Z

This doesn't seem to be working right for me on the available tab, …

The available tab seems to be working fine

Where does it work and where doesn't it?

timja · 2020-04-16T13:21:15Z

Doesn't work properly (the input is focused, and my cursor is blinking there):

Available tab is fine

core/src/main/resources/hudson/PluginManager/_table.js

timja

LGTM

timja · 2020-04-17T21:27:52Z

Thanks for the PR, nice improvement

Let’s merge this in 24 hours if no negative feedback

Allow linking to pre-filtered plugin manager pages, link from labels/…

c4e5234

…tags

daniel-beck added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Mar 17, 2020

daniel-beck requested a review from fqueiruga March 17, 2020 01:21

fqueiruga reviewed Mar 17, 2020

View reviewed changes

daniel-beck added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Mar 17, 2020

daniel-beck assigned fqueiruga Mar 17, 2020

oleg-nenashev added the web-ui The PR includes WebUI changes which may need special expertise label Mar 17, 2020

fqueiruga and others added 3 commits March 20, 2020 11:49

Add custom hyperlink styles for the category pills

a4c456c

Merge pull request #3 from fqueiruga/style-category-badges

3498a52

Add custom hyperlink styles for the category pills

Merge branch 'master' into linkable-filter-field

1eb4f3b

daniel-beck removed the on-hold This pull request depends on another event/release, and it cannot be merged right now label Mar 22, 2020

daniel-beck unassigned fqueiruga Mar 22, 2020

fqueiruga approved these changes Mar 23, 2020

View reviewed changes

daniel-beck mentioned this pull request Mar 28, 2020

Pre-filter the 'Available' plugin manager tab, allow multiple terms #4580

Merged

9 tasks

varyvol approved these changes Apr 16, 2020

View reviewed changes

varyvol added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 16, 2020

Merge branch 'master' into linkable-filter-field

a4e190f

daniel-beck self-assigned this Apr 16, 2020

daniel-beck added 2 commits April 16, 2020 13:35

Merge branch 'linkable-filter-field' of github.com:daniel-beck/jenkin…

12523a5

…s into linkable-filter-field

Make this look better while the page is loading

dd7285d

daniel-beck removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 16, 2020

daniel-beck requested review from fqueiruga, varyvol and timja April 16, 2020 12:08

fqueiruga approved these changes Apr 16, 2020

View reviewed changes

daniel-beck commented Apr 16, 2020

View reviewed changes

core/src/main/resources/hudson/PluginManager/_table.js Outdated Show resolved Hide resolved

Fix JS issue on tabs other than "Available"

77bdf35

timja approved these changes Apr 16, 2020

View reviewed changes

timja requested a review from a team April 16, 2020 19:49

daniel-beck removed their assignment Apr 17, 2020

timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 17, 2020

timja merged commit 7b654b2 into jenkinsci:master Apr 19, 2020

daniel-beck mentioned this pull request Apr 19, 2020

Link from cloud configuration to pre-filtered plugin manager #4669

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

daniel-beck commented Mar 17, 2020 •

edited

fqueiruga Mar 17, 2020

daniel-beck Mar 17, 2020

fqueiruga Mar 17, 2020

fqueiruga Mar 22, 2020

daniel-beck Mar 22, 2020

timja commented Mar 28, 2020

daniel-beck commented Mar 28, 2020

timja commented Mar 28, 2020

fqueiruga commented Apr 13, 2020

timja commented Apr 13, 2020

daniel-beck commented Apr 16, 2020

timja commented Apr 16, 2020

daniel-beck commented Apr 16, 2020

timja commented Apr 16, 2020 •

edited

timja left a comment

timja commented Apr 17, 2020

Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

Allow linking to pre-filtered plugin manager pages, link from labels/… #4591

Conversation

daniel-beck commented Mar 17, 2020 • edited

Screenshot

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

fqueiruga Mar 17, 2020

Choose a reason for hiding this comment

daniel-beck Mar 17, 2020

Choose a reason for hiding this comment

fqueiruga Mar 17, 2020

Choose a reason for hiding this comment

fqueiruga Mar 22, 2020

Choose a reason for hiding this comment

daniel-beck Mar 22, 2020

Choose a reason for hiding this comment

timja commented Mar 28, 2020

daniel-beck commented Mar 28, 2020

timja commented Mar 28, 2020

fqueiruga commented Apr 13, 2020

timja commented Apr 13, 2020

daniel-beck commented Apr 16, 2020

timja commented Apr 16, 2020

daniel-beck commented Apr 16, 2020

timja commented Apr 16, 2020 • edited

timja left a comment

Choose a reason for hiding this comment

timja commented Apr 17, 2020

daniel-beck commented Mar 17, 2020 •

edited

timja commented Apr 16, 2020 •

edited