Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commons codec cleanup #4636

Merged
merged 2 commits into from
Apr 11, 2020
Merged

Conversation

jvz
Copy link
Member

@jvz jvz commented Apr 8, 2020

https://commons.apache.org/proper/commons-codec/changes-report.html#a1.14

Also includes some refactoring to remove need to use Base64 from commons-codec.

Proposed changelog entries

  • Internal: Upgrade commons-codec to 1.14

Proposed upgrade guidelines

N/A

Submitter checklist

  • JIRA issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

jvz added 2 commits April 8, 2020 15:25
Signed-off-by: Matt Sicker <boards@gmail.com>
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the library change, we have to run PCT to validate this PR :)

Good initiative to move the Base64!

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's nice to get these things updated and cleaned up.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need it in the changelog, maybe only as a developer entry. I plan to merge it tomorrow if no negative feedback

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 10, 2020
@oleg-nenashev oleg-nenashev merged commit 13966d2 into jenkinsci:master Apr 11, 2020
@jvz jvz deleted the commons-codec-cleanup branch April 14, 2020 21:58
@jvz
Copy link
Member Author

jvz commented Jun 8, 2020

@timja
Copy link
Member

timja commented Jun 28, 2020

Configuration as code users are hitting this as well: jenkinsci/configuration-as-code-plugin#1425 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants