-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commons codec cleanup #4636
Commons codec cleanup #4636
Conversation
Signed-off-by: Matt Sicker <boards@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the library change, we have to run PCT to validate this PR :)
Good initiative to move the Base64!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It's nice to get these things updated and cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need it in the changelog, maybe only as a developer entry. I plan to merge it tomorrow if no negative feedback
Configuration as code users are hitting this as well: jenkinsci/configuration-as-code-plugin#1425 (comment) |
https://commons.apache.org/proper/commons-codec/changes-report.html#a1.14
Also includes some refactoring to remove need to use
Base64
from commons-codec.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate