Theme alert-* css classes and add alert-success #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
added
web-ui
fqueiruga
approved these changes
Jul 10, 2020
fqueiruga
reviewed
Jul 10, 2020
Comment on lines
92
to
101
| --notification-warn-icon-color: #ff9800; | ||
| --notification-warn-bg-color: #fff3cd; | ||
| --notification-warn-border-color: #ffeeba; | ||
| --notification-warn-color: #856404; | ||
|
|
||
| // Error | ||
| --alert-err-icon-color: #f44336; | ||
| --alert-err-bg-color: #f8d7da; | ||
| --alert-err-border-color: #f5c6cb; | ||
| --alert-err-color: #721c24; | ||
| --notification-err-icon-color: #f44336; | ||
| --notification-err-bg-color: #f8d7da; | ||
| --notification-err-border-color: #f5c6cb; | ||
| --notification-err-color: #721c24; |
There was a problem hiding this comment.
Nitpicking but shouldn't we use the same naming scheme as on the other ones? Either warn & err or warning & danger.
There was a problem hiding this comment.
I'll adjust these ones, (but they were already inconsistent)
There was a problem hiding this comment.
Whatever you consider best!
timja
changed the title
timja
commented
Jul 12, 2020
oleg-nenashev
approved these changes
Jul 17, 2020
|
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process |
oleg-nenashev
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).