[JENKINS-60563] Replace MD5 with SHA-256 in ConsistentHash #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also update outdated link - Reformat some of the code - Adjust the tests - Ignore the performance test - Correct typos
timja
approved these changes
Oct 24, 2020
why have it then? |
Used in Jenkins core only :) (description updated) |
StefanSpieker
approved these changes
Oct 25, 2020
res0nance
approved these changes
Oct 26, 2020
| @@ -183,18 +185,20 @@ public String hash(String str) { | |||
| * This test doesn't fail but it's written to measure the performance of the consistent hash function with large data set. | |||
| */ | |||
| @Test | |||
| @Ignore("Helper test for performance, no assertion") | |||
There was a problem hiding this comment.
Fine with me, is the performance difference for this implementation noteworthy?
There was a problem hiding this comment.
No tested due to Hash function comparison, the difference should be around 5-10% between MD5 and SHA-256.
It's not like we are moving from MD5 to BCrypt :)
jvz
approved these changes
Oct 26, 2020
oleg-nenashev
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Fine with me. Maybe it is a good time to deprecate the class also.
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
oleg-nenashev
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ No usage of that class in the ecosystem (Edit: outside Jenkins core that is using it for Queue)
⚠️ For CloudBees, please check Slack.
See JENKINS-60563.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).