-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-64666] document urls #5652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the links are broken in Jenkins 2.289.2 and work in Jenkins 2.305-SNAPSHOT as built from this pull request. Fixed links include:
- Jenkins CLI
- Jenkins core
- Jenkins war
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, thanks!
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
[JENKINS-64666] document urls (jenkinsci#5652)
See JENKINS-64666.
Document modules with project urls. This will allow
/about
page to build correct links.Proposed changelog entries
Provide working "Help About" links for Jenkins CLI, Jenkins core, and Jenkins war
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeMaintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).