Test result page keeps identifying tests as age 1 #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a test has not been viewed, the age will keep being 1. This is because getFailedSince()/failedSince is lazy loaded. Without having viewed the CaseResult that method is never called and the prev.failedSince returns '0' which may or may not be accurate. http://jenkins.361315.n4.nabble.com/Problem-with-Age-column-on-Test-Results-tab-td3172208.html
ghost
assigned 
|
This appears to fix JENKINS-18626. |
|
@wolfs |
|
Seems good to me. Why did you want my input on this? |
|
You're the most active contributor of hudson.tasks.junit.* |
|
I must admit I only fixed a link and added some tests. So I mainly was working with the jelly files and never had a look at this part of the code. So I am not sure if my input is really valuable. |
oleg-nenashev
added a commit
that referenced
this pull request
Jun 1, 2014
[FIXED JENKINS-18626] - Test result page keeps identifying tests as age 1
oleg-nenashev
added a commit
that referenced
this pull request
Jun 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test has not been viewed, the age will keep being '1'.
This is because getFailedSince()/failedSince is lazy loaded.
Without having viewed the CaseResult that method is never
called and the prev.failedSince returns '0' which may or may
not be accurate.
Example: http://jenkins.361315.n4.nabble.com/Problem-with-Age-column-on-Test-Results-tab-td3172208.html